Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prismic unsplash image proxy #1614

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Nov 27, 2024

πŸ”— Linked issue

Resolves: #1600

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Some images distributed through Prismic are images directly served by Unsplash's CDN. This PR takes that into account within the Prismic provider to redirect Unsplash images to the Unsplash provider.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 62.93%. Comparing base (d2e4eb0) to head (a609f24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   62.98%   62.93%   -0.06%     
==========================================
  Files          79       79              
  Lines        3534     3529       -5     
  Branches      406      407       +1     
==========================================
- Hits         2226     2221       -5     
  Misses       1279     1279              
  Partials       29       29              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Collaborator

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @lihbr !

@danielroe danielroe merged commit 7f33656 into main Nov 29, 2024
3 checks passed
@danielroe danielroe deleted the fix/prismic-unsplash-image-proxy branch November 29, 2024 10:11
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prismic provider doesn't work when selecting a placeholder image from Unsplash
4 participants