This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
feat!: disable ssr by default #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released as 0.1.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables server-side rendering by default when in vite mode. (development)
We have a working server implementation (src) based on vite's rollup production build but it is not a proper implementation and even vite-plugin-vue2 has not SSR support! (it is working by workaround) causing issues like #7, slower build times, and overall worst developer experience.
The downside of doing this change is that it makes it harder to discover SSR issues (like hydration errors or module incompatibility) but makes it easier for adoption. For (
nuxt-vite) development and tests, SSR is still enabled. Also, production builds use webpack for SSR so it only affects development.New options: (
nuxt.config)vite.ssr(boolean or vite ssr options)vite.experimentWarning(allows disabling banner)