-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
===========================================
- Coverage 90.16% 76.44% -13.72%
===========================================
Files 11 11
Lines 183 242 +59
Branches 43 53 +10
===========================================
+ Hits 165 185 +20
- Misses 18 57 +39
Continue to review full report at Codecov.
|
For testing, do you think we should introduce cypress for e2e test? |
Co-authored-by: Daniel Roe <daniel@roe.dev>
'nuxt-vite' | ||
], | ||
vite: { | ||
build: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pi0 Should we make it default to true and for users to opt-out? Or maybe in next breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for next major (0.3.x) so that we can fix leftover issues like modern mode mapping, speeding up and better legacy.
This PR introduces the ability to run
nuxt build
use Vite, resolve #167. close #7This also made Nuxt 2 working with vite plugins, tested with https://github.com/antfu/vitesse-nuxt/tree/play/vite-build
The build is disable by default, and can be enabled with:
Ideally we would like to make it default to true, but do we want to release is as opt-in experimental feature and change it in the future (or we have it default to
true
and releases with beta dist?) /cc @pi0 @atinux WDYT?This should be released as a minor change.