Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Validation error comments should specify the failing URL #3253

Open
XLTechie opened this issue Apr 16, 2024 · 1 comment
Open

404 Validation error comments should specify the failing URL #3253

XLTechie opened this issue Apr 16, 2024 · 1 comment
Labels

Comments

@XLTechie
Copy link
Contributor

Actual:

If the submission validation scripts encounter a failing URL, the error left as a comment on the issue does not specify the URL.
The submitter may not therefore know which URL is failing to resolve, and may waste time trying to debug URLs that aren't the problem.

Example:

Validation Errors for addons/ADDON_NAME/VERSION.json:
• Fatal error, unable to continue: HTTP Error 404: Not Found

Expected:

The failing URL is given in the comment.

Example:

Validation Errors for addons/ADDON_NAME/VERSION.json:
• Fatal error, unable to continue: HTTP Error 404: Not Found
URL: https://something.tld/someUser/ADDON_NAME-VERSION.nvda-addon

Additional Context:

First noticed in #3244.

@XLTechie
Copy link
Contributor Author

XLTechie commented Apr 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants