From 9157916f4c228e86dbfbd55de6c34a814fc8c47a Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Fri, 21 Jul 2023 13:32:13 +1000 Subject: [PATCH] Fix 'flickUp' text review touch gesture (#15171) Closes #15127 Fix up of #14021 Summary of the issue: #14021 accidentally overwrote the touch gesture to move to the previous line in text review mode. These overwritten gestures were not documented in the user guide, and appear to be unintentional. Description of user facing changes Remove overwritten "flickUp" gestures. Description of development approach Remove overwritten "flickUp" gestures. --- source/globalCommands.py | 6 +++--- user_docs/en/changes.t2t | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 587248fbbe2..5bd5d3f601e 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -273,7 +273,7 @@ def script_reportCurrentSelection(self,gesture): speech.speakMessage(_("No selection")) else: speech.speakTextSelected(info.text) - + @script( # Translators: Input help mode message for report date and time command. description=_("If pressed once, reports the current time. If pressed twice, reports the current date"), @@ -1591,7 +1591,7 @@ def script_review_nextLine(self, gesture: inputCore.InputGesture): description=_("Moves the review cursor to the previous page of the current navigator object and speaks it"), resumeSayAllMode=sayAll.CURSOR.REVIEW, category=SCRCAT_TEXTREVIEW, - gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp", "ts(text):flickUp") + gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp") ) def script_review_previousPage(self, gesture: inputCore.InputGesture) -> None: info = api.getReviewPosition().copy() @@ -1623,7 +1623,7 @@ def script_review_previousPage(self, gesture: inputCore.InputGesture) -> None: description=_("Moves the review cursor to the next page of the current navigator object and speaks it"), resumeSayAllMode=sayAll.CURSOR.REVIEW, category=SCRCAT_TEXTREVIEW, - gestures=("kb:NVDA+pageDown", "kb(laptop):NVDA+shift+pageDown", "ts(text):flickUp") + gestures=("kb:NVDA+pageDown", "kb(laptop):NVDA+shift+pageDown") ) def script_review_nextPage(self, gesture: inputCore.InputGesture) -> None: origInfo = api.getReviewPosition().copy() diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index 79ec163a4c4..d3e79a040aa 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -128,6 +128,7 @@ This can be disabled in the Advanced Settings panel. (#7756) - NVDA now generally responds slightly faster to commands and focus changes. (#14928) - Displaying the OCR settings will not fail on some systems anymore. (#15017) - Fix bug related to saving and loading the NVDA configuration, including switching synthesizers. (#14760) +- Fix bug causing text review "flick up" touch gesture to move pages rather than move to previous line. (#15127) -