Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons setting in core.concealer module does not override / combine with icon_preset setting #863

Closed
2 tasks done
dasupradyumna opened this issue May 12, 2023 · 0 comments · Fixed by #908
Closed
2 tasks done
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.

Comments

@dasupradyumna
Copy link

dasupradyumna commented May 12, 2023

Prerequisites

  • I am using the latest stable release of Neovim
  • I am using the latest version of the plugin

Neovim Version

NVIM v0.10.0-dev

Neorg setup

require('neorg').setup {
  load = {
    ['core.defaults'] = {},
    ['core.concealer'] = {
      config = {
        -- icon_preset = 'diamond',
        -- BUG: preset+override not working?
        icons = {
          heading = {
            level_1 = { icon = '' },
            level_2 = { icon = '' },
            level_3 = { icon = '' },
            level_4 = { icon = '' },
            level_5 = { icon = '' },
            level_6 = { enabled = false },
          },
        },
      },
    },
    ['core.dirman'] = { config = { workspaces = { journal = '~/journal' } } },
  },
}

Actual behavior

I only wished to change the header icons while the icon_preset is set to "diamond". But if I set the icon_preset, the icon settings are ignored; and if i remove the icon_preset, the icon settings work but remaining icons belong to the "basic" preset.
Only the level_6 = { enabled = false } takes effect (heading 6 gets disabled), but other icons are still fetched from "basic".

Is this intended behavior?

Expected behavior

I thought the setting the icon_preset and configuring icons would merge both settings, i.e getting "diamond" icons by default but only override the header icons.

Steps to reproduce

Just open a norg file in NeoVim.

Potentially conflicting plugins

None

Other information

No response

Help

None

Implementation help

No response

@dasupradyumna dasupradyumna added the bug Issues related to bugs. Please attach a severity, a priority and category with this label. label May 12, 2023
@github-project-automation github-project-automation bot moved this to added-updated-reopened in sorting neorg issue tracker May 12, 2023
@d-r-a-b d-r-a-b moved this from added-updated-reopened to low-hanging-fruit in sorting neorg issue tracker May 20, 2023
@github-project-automation github-project-automation bot moved this from low-hanging-fruit to done in sorting neorg issue tracker Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant