feat(summary): reimplement nested categories #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(summary): pass subcategories by argument chore(summary): refactor subcategory adding fix(summary): work when no catagories are given
|
I can confirm it works on my end! Thanks a lot for the PR :D |
gruejay
pushed a commit
to gruejay/neorg
that referenced
this pull request
Jan 31, 2024
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Feb 6, 2024
vhyrro
pushed a commit
that referenced
this pull request
Feb 17, 2024
sahinf
pushed a commit
to sahinf/neorg
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Looks like nested categories were added to the summary module but then later disabled.
What:
This adds it back in with some subtle changes so it works with the current codebase. It also plays nicely with selecting the desired (sub)categories by argument given. Did a little refactoring to shorten the default strategy function and make it easier to read.
This is my first time submitting a PR. I'm just too excited about Neorg to hold back. Feedback appreciated.