Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding control #25

Closed
danunafig opened this issue Nov 15, 2022 · 2 comments
Closed

Encoding control #25

danunafig opened this issue Nov 15, 2022 · 2 comments

Comments

@danunafig
Copy link
Contributor

Hey,
I guess it would be nice to let users control stdout encoding. As long as spawn cannot have "encdoing" , there is an option to support it with runOptions:

async run(userArguments, runOptions = {}) {
++runOptions.encoding = runOptions.encoding || 'utf8';
...
child = spawn(javaExe, javaArgs, spawnOptions);
++child.stdout.setEncoding(runOptions.encoding);
...

@nvuillam
Copy link
Owner

Nice idea :)

Would you like to make a pull request ? :)

@nvuillam
Copy link
Owner

Fixed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants