Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads structure changed #3547

Open
adam-lynch opened this issue Jun 4, 2015 · 2 comments
Open

Downloads structure changed #3547

adam-lynch opened this issue Jun 4, 2015 · 2 comments

Comments

@adam-lynch
Copy link

Previously, there were directories like http://dl.nwjs.io/v0.12.0-alpha3/ for alpha builds. Now, there's http://dl.nwjs.io/v0.13.0 which isn't ready yet and just contains an alpha directory. This has broken node-webkit-builder's download of NW.js (nwutils/nw-builder#222). Is this the way the downloads will be structured from now on?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rogerwang
Copy link
Member

Hi Adam, Thanks for reporting this. I didn't know node-webkit-builder is replying on this. Because many alpha versions for 0.13.0 was planned and I don't want to mess the root directory so it's been put in /v0.13.0 . The files for the final version will be in this directory, while the alpha and RC versions will be put in sub-directories.

I'm working on a release script which will put a JSON file to describe this in the root directory, but it won't be ready before 0.13.0 release.

@adam-lynch
Copy link
Author

@rogerwang no problem. I fixed it last night so that when we're finding the latest version, we also send a HEAD request to the windows 64-bit ZIP just to validate that the version isn't just an alpha build.

I'm working on a release script which will put a JSON file to describe this in the root directory, but it won't be ready before 0.13.0 release.

That would be lovely.


If for each release it had links to each of the platform ZIPs then that would be great. It would save us doing more stuff like assuming a Windows 32-bit ZIP follows the v${ version }/${ name }-v${ version }-win-ia32.zip pattern.

As you can see here https://github.com/mllrsohn/node-webkit-builder/blob/master/lib/platforms.js#L7 we have to track which files (icudtl.dat, etc.) are needed per platform per version too. This is messy and I don't think it's even correct right now. So if the JSON file also had these details (or another JSON file inside of each release directory) then that would be amazing.

I'd probably then make a new module for just getting a specific / the latest NW.js version, getting the files, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants