Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo when using macZip true #100

Closed
wants to merge 1 commit into from

Conversation

rlee1121
Copy link

As per #86, when macZip: true is set, the app zip is being copied into nw.icns instead of app.nw

@adam-lynch
Copy link
Contributor

FYI, #99 will be merged first tomorrow. This will now be on line 422.

This PR will need to be re-done I think after #99 is merged.

While we're at it, you know what would be amazing? If you could add a test which proves the ZIP created is incorrect. Would you be up for that? 😄

@adam-lynch
Copy link
Contributor

FYI, the other PR was merged so this needs to be updated.

adam-lynch added a commit that referenced this pull request Nov 26, 2014
adam-lynch added a commit that referenced this pull request Nov 26, 2014
@adam-lynch
Copy link
Contributor

I've changed it myself. Thanks for the PR anyway! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants