This repository has been archived by the owner on Oct 16, 2021. It is now read-only.
Fixed 5B Instrument Recording #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i swear i'll look at this at some point |
nyanpasu64
reviewed
Jun 27, 2019
Source/InstrumentRecorder.cpp
Outdated
| @@ -216,7 +216,8 @@ void CInstrumentRecorder::RecordInstrument(const unsigned Tick, CView *pView) / | |||
| } | |||
| break; | |||
| case SNDCHIP_S5B: | |||
| Val = 0x1F & REG(0x06) | (0x10 & REG(0x08 + ID)) << 1 | |||
| //0x1F accounts for inverted noise period value | |||
| Val = 0x1F & (0x1F - REG(0x06)) | (0x10 & REG(0x08 + ID)) << 1 | |||
There was a problem hiding this comment.
this looks a bit suspicious, maybe 0x1F - (0x1F & REG(0x06)) is more correct, idk I haven't compiled the code yet.
|
"this looks a bit suspicious, maybe 0x1F - (0x1F & REG(0x06)) is more correct" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.