Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Composer change event is not fired when all text is deleted #468

Open
loomchild opened this issue Jan 24, 2023 · 1 comment
Open

Comments

@loomchild
Copy link

loomchild commented Jan 24, 2023

Describe the bug
Composer change event is not fired on empty text (for example, when I select all the text and delete it).

To Reproduce

  1. Register a change handler on <nylas-composer> component, logging out all messages
  2. When text is added or part of it deleted, the handler is correctly fire. However, if I delete all text, it's not fire.

(Please let me know if above is sufficient - I can provide a CodePen similar if necessary)

Expected behavior
Composer should fire change event when all text is deleted. I am uncertain if this event should also be fired with empty text during initialization.

Version:
1.1.6-canary.20in

Additional context
The issue seems to be in this line, because if (onchange) onchange(html) is only being run if html is not falsy.

@xtaraim
Copy link

xtaraim commented Dec 13, 2023

thdsh sgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants