Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add umbrella header #62

Closed
soffes opened this issue Jul 17, 2015 · 2 comments
Closed

Add umbrella header #62

soffes opened this issue Jul 17, 2015 · 2 comments
Labels
enhancement

Comments

@soffes
Copy link

soffes commented Jul 17, 2015

It's unexpected that the following doesn't work:

#import <NYTPhotoViewer/NYTPhotoViewer.h>

It would be great if there was an umbrella header. This will be required for #61 anyway :)
@MichaelSelsky MichaelSelsky mentioned this issue Jul 20, 2015
Closed
@cdzombak cdzombak self-assigned this Oct 19, 2015
@cdzombak cdzombak removed their assignment Jan 4, 2016
@cdzombak cdzombak mentioned this issue Feb 29, 2016
Closed
@cdzombak
Copy link
Contributor

cdzombak commented Mar 7, 2016

Completed in #164. (Thanks, @davbeck!)

@cdzombak cdzombak closed this as completed Mar 7, 2016
@haithngn
Copy link

still happend on the latest commit (develop branch)

Warning:(1, 1) umbrella header for module 'NYTPhotoViewerCore' does not include header 'NYTPhotoViewerArrayDataSource.h'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soffes @cdzombak @haithngn