Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Loading #64

Closed
hhanesand opened this issue Jul 27, 2015 · 0 comments
Closed

Image Loading #64

hhanesand opened this issue Jul 27, 2015 · 0 comments
Assignees
Labels

Comments

@hhanesand
Copy link

There seems to be a problem with the way this library loads images from its resources bundle.

From the looks of it you guys are using [UIImage imageNamed:] in NYTPhotosViewController, which searches the main bundle. On my device, that doesn't work, and the image is not loaded. I'm not very familiar with the way Cocoapods works, but it may have something to do with the fact that I'm using use_frameworks! in my podfile.

I think the easiest way to fix this is to use [UIImage imageNamed:inBundle:compatibleWithTraitCollection:] with the bundle received from [NSBundle bundleForClass:], as that will load the image from the appropriate bundle.

Just as a side note, I see you guys are using resources and not resource_bundles in your podspec, and I think the cocoapods team has deprecated resources in favor of resource_bundles.

Thanks in advance for replies 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants