Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button not showing #75

Closed
flocbit opened this issue Oct 8, 2015 · 1 comment
Closed

Close button not showing #75

flocbit opened this issue Oct 8, 2015 · 1 comment
Assignees
Labels

Comments

@flocbit
Copy link

flocbit commented Oct 8, 2015

I am using the latest version of NYT and everything is working absolutely fine except the close button is hidden since I switched to cocoapods use_frameworks. Does anyone have any idea how to solve this issue?

Thanks :)

EDIT: Seems to be related to this issue: #64
I'm using cocoapods and use_frameworks as well.

@flocbit flocbit changed the title Close button not showing on iOS 9 Close button not showing Oct 8, 2015
@flocbit
Copy link
Author

flocbit commented Oct 8, 2015

Thanks to @hhanesand I could solve it:

NYTPhotosViewController.m line 156

_overlayView.leftBarButtonItem = [[UIBarButtonItem alloc] initWithImage:[UIImage imageNamed:@"NYTPhotoViewerCloseButtonX" inBundle:[NSBundle bundleForClass:[NYTPhotosOverlayView class]] compatibleWithTraitCollection:nil] landscapeImagePhone:[UIImage imageNamed:@"NYTPhotoViewerCloseButtonXLandscape"] style:UIBarButtonItemStylePlain target:self action:@selector(doneButtonTapped:)];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants