From bcd09ef0e93406c977f19322f8c2c0ca0ce41301 Mon Sep 17 00:00:00 2001 From: Mikhail Volkhov Date: Thu, 29 Feb 2024 19:06:12 +0000 Subject: [PATCH] Revert "Expression evaluation: evaluate over D2 instead of D1" This reverts commit be3d64e918183a68383709a5894c913dd62cca8f. --- kimchi/src/circuits/expr.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/kimchi/src/circuits/expr.rs b/kimchi/src/circuits/expr.rs index 0115bc7001..d676d97d0e 100644 --- a/kimchi/src/circuits/expr.rs +++ b/kimchi/src/circuits/expr.rs @@ -1844,13 +1844,8 @@ impl Expr { ) -> Evaluations> { let d1_size = env.get_domain(Domain::D1).size; let deg = self.degree(d1_size, env.get_constants().zk_rows); - // TODO @volhovm I'm not sure about this change, but otherwise we get a trivial polynomial. - // It never makes sense to evaluate expression over D1, since then we just get zero. - let d = if deg <= 2 * d1_size { - Domain::D2 - //let d = Domain::D4; - // let d = if deg <= 2 * d1_size { - // Domain::D2 + let d = if deg <= d1_size { + Domain::D1 } else if deg <= 4 * d1_size { Domain::D4 } else if deg <= 8 * d1_size {