From 0b8caa0b52bdd1eddb585ecef8eaa8f8b73d4e88 Mon Sep 17 00:00:00 2001 From: Luke-zhang-04 Date: Thu, 5 Nov 2020 11:56:17 -0500 Subject: [PATCH] refactor: use `map.contains_key()` instead of iterating using map.contains_key is easier to understand and probably has better lookup time Signed-off-by: Luke-zhang-04 --- src/onefetch/deps/mod.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/onefetch/deps/mod.rs b/src/onefetch/deps/mod.rs index 8a2151167..ccc122707 100644 --- a/src/onefetch/deps/mod.rs +++ b/src/onefetch/deps/mod.rs @@ -40,12 +40,6 @@ impl DependencyDetector { DependencyDetector { package_managers } } - fn is_package_file(&self, file_name: &str) -> bool { - self.package_managers.iter().any(|(package_manager_file_name, _)| { - file_name.starts_with(package_manager_file_name) - }) - } - pub fn get_deps_info(&self, dir: &str) -> Result { let deps = fs::read_dir(dir) .chain_err(|| "Could not read directory")? @@ -56,7 +50,7 @@ impl DependencyDetector { && entry .file_name() .map(OsStr::to_string_lossy) - .map(|s| self.is_package_file(s.as_ref())) + .map(|s| self.package_managers.contains_key(s.as_ref())) .unwrap_or_default() }) .map(|entry| {