Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react props #14

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Fix react props #14

merged 2 commits into from
Nov 29, 2019

Conversation

viktor-yakubiv
Copy link
Member

No description provided.

@viktor-yakubiv viktor-yakubiv self-assigned this Nov 29, 2019
@Joozty
Copy link
Member

Joozty commented Nov 29, 2019

Thanks, I also noticed eslint-plugin-import doesn't sort imports alphabetically. There is PR opened. I believe they will solve it anytime soon. It could be really useful for us.

import-js/eslint-plugin-import#1105

@viktor-yakubiv
Copy link
Member Author

I think we have to order imports logically not alphabetically. Let's consider it later.

@viktor-yakubiv viktor-yakubiv merged commit fd0684a into master Nov 29, 2019
@viktor-yakubiv viktor-yakubiv deleted the react branch November 29, 2019 13:56
@Joozty
Copy link
Member

Joozty commented Nov 29, 2019

I meant to sort every group alphabetically. It can be really useful when rebasing some big PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joozty Joozty Joozty approved these changes

Assignees

@viktor-yakubiv viktor-yakubiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktor-yakubiv @Joozty