Add support for sapphire-paratime 2.x #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
2 times, most recently
from
e1f11cf
to
536f5af
Compare
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
from
536f5af
to
746a641
Compare
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
2 times, most recently
from
7b94b2d
to
296b961
Compare
rube-de
reviewed
Oct 25, 2024
frontend/package.json
Outdated
There was a problem hiding this comment.
I think this can just point now to ^0.2.11 and ^2.0.1 as the mentioned issues are merged
| type Provider, | ||
| type Signer, | ||
| toBeHex, | ||
| toBeHex, toUtf8Bytes, |
There was a problem hiding this comment.
Suggested change
| toBeHex, toUtf8Bytes, | |
| toBeHex, | |
| toUtf8Bytes, |
|
This PR should be now merged in the vue branch. |
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
2 times, most recently
from
1241376
to
34d471c
Compare
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
from
34d471c
to
11c2ae8
Compare
matevz
force-pushed
the
matevz/sapphire-paratime-2.0
branch
from
11c2ae8
to
3b27751
Compare
This would break, current React rewrite, as it is based on "v1". Can we hold off merging? Until rewrite of frontend is done on top of this PR? cc: @matevz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Merge after oasisprotocol/sapphire-paratime#332 and oasisprotocol/sapphire-paratime#303