Time 0.1.41 breaks the build

[armaniferrante]

time 0.1.41 breaks the build, due to multiple inner modules being defined in sys.rs, when building enclaves.

I suspect this change is responsible time-rs/time@9bdff26, because things only break when we run cargo ekiden build-enclave. For an example, see https://buildkite.com/oasislabs/ekiden/builds/235#_.

As a stopgap, we've pinned the dependency to 0.1.40 in #1233

[matevz]

It seems a trivial fix is required by upstream in https://github.com/rust-lang-deprecated/time/blob/master/src/sys.rs#L350
#[cfg(unix)] -> #[cfg(all(unix, not(target_env = "sgx")))]
and in https://github.com/rust-lang-deprecated/time/blob/master/src/sys.rs#L690
#[cfg(windows)] -> #[cfg(all(windows, not(target_env = "sgx")))]

Should I make a fork to oasislabs/ org and make PR to upstream?

[matevz]

Created upstream issue time-rs/time#175

[matevz]

Created upstream PR: time-rs/time#176
In the mean time, we can use https://github.com/oasislabs/time crate.

[kostko]

I think we can use the old version for now unless there are changes that we desperately need?

[matevz]

Yeah, we can just wait for the upstream to fix it. So once time-rs/time#175 is closed, time crate version should be unpinned and this issue closed.

[kostko]

I think the correct solution is to use target_vendor = "fortanix", see the following issue rust-lang/rust#57231.