Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aut 3876/editor passage remove #171

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

olga-kulish
Copy link
Contributor

@olga-kulish olga-kulish commented Nov 1, 2024

Related to https://oat-sa.atlassian.net/browse/AUT-3876

Deployed to unit01

  1. Add TextReaderInteraction PCI.
  2. Insert Passage inside it (apply Fix/aut 3876/editor passage remove extension-tao-itemqti#2605).
    Or, insert Image inside it and stretch it to fill 100% of the page width.
  3. --> remove button is not fully visible, because it goes outside scrollable container borders.
  4. --> trashcan icon is misplaced

Screenshot_11

Screenshot_12

Copy link

github-actions bot commented Nov 1, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
0 0 0 0

@olga-kulish olga-kulish force-pushed the fix/AUT-3876/editor-passage-remove branch from c61e42f to a272175 Compare November 1, 2024 09:24
Copy link

github-actions bot commented Nov 4, 2024

Version

Target Version 3.9.1
Last version 3.9.0

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS and version changes look fine.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master (or main) - or is a release
  • Bundled code is present if needed
  • Version bump is applied if needed (packages AND root)
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@olga-kulish olga-kulish self-assigned this Nov 13, 2024
@olga-kulish olga-kulish merged commit d5063af into develop Nov 13, 2024
5 checks passed
@olga-kulish olga-kulish deleted the fix/AUT-3876/editor-passage-remove branch November 13, 2024 10:00
wazelin added a commit to oat-sa/tao-community that referenced this pull request Nov 21, 2024
…eases/tag/v54.20.1.1)**

- _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#4125](oat-sa/tao-core#4125) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish)
**[oat-sa/extension-tao-itemqti v30.20.0.2](https://github.com/oat-sa/extension-tao-itemqti/releases/tag/v30.20.0.2)**
 - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#2613](oat-sa/extension-tao-itemqti#2613) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
 - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#2605](oat-sa/extension-tao-itemqti#2605) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
**[oat-sa/extension-pcisample v3.9.2](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.2)**
 - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#172](oat-sa/extension-pcisample#172) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
**[oat-sa/extension-pcisample v3.9.1](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.1)**
 - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#171](oat-sa/extension-pcisample#171) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants