Fix/aut 3923/textreader image figure support #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
This was referenced Nov 8, 2024
added 2 commits
November 14, 2024 13:00
…mqti into fix/AUT-3923/textreader-image-figure-support
Version
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
wazelin
added a commit
to oat-sa/tao-community
that referenced
this pull request
Nov 21, 2024
…eases/tag/v54.20.1.1)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#4125](oat-sa/tao-core#4125) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) **[oat-sa/extension-tao-itemqti v30.20.0.2](https://github.com/oat-sa/extension-tao-itemqti/releases/tag/v30.20.0.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#2613](oat-sa/extension-tao-itemqti#2613) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#2605](oat-sa/extension-tao-itemqti#2605) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.2](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#172](oat-sa/extension-pcisample#172) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.1](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.1)** - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#171](oat-sa/extension-pcisample#171) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3923
Changes
htmlEditor.js & elementSupport.js & Img.jsWhen you position image as left/right/center,
<figure class="wrap-left"><img></figure>is created<img class="wrap-left">is createdfigurecan be createdfigurecauses backend error "QTI XML compilation error"" on save, so disable it like in Choice.Widget.jsExplicitly set
contenteditable=false, because otherwise<figcaption>is editable in TextReaderInteraction PCI. It is not editable in A-block or QTI interaction prompt/choice.I have no idea what's the difference and how to implement this properly.
item-creator.scssWhen you wrap image inside Choice of ChoiceInteraction, it goes outside Choice borders.
Test
On unit05. Related PRs: