Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a fix to cover infinity recursive call #1139

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add a fix to cover infinity recursive call #1139

wants to merge 1 commit into from

Conversation

shpran
Copy link
Contributor

@shpran shpran commented Nov 14, 2024

Goal

Use getParentClassesIds recursive call in isInstanceOf method to improve performance.

Issue

When using isInstanceOf with getParentClassesIds recursive call on properties, it stuck due to infinity recursive call, because http://www.w3.org/2000/01/rdf-schema#Class type points to itself.

TODO

  • Check other types of resources to be compatible with new solution

@shpran shpran requested a review from gabrielfs7 November 14, 2024 11:49
@github-actions GitHub Actions
Copy link

Version

Target Version 15.39.2
Last version 15.39.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@shpran shpran marked this pull request as draft November 14, 2024 11:51
@gabrielfs7 gabrielfs7 marked this pull request as ready for review December 12, 2024 11:32
gabrielfs7
gabrielfs7 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @shpran

Before merge we need to ask QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielfs7 gabrielfs7 gabrielfs7 approved these changes

@tikhanovichA tikhanovichA Awaiting requested review from tikhanovichA

@Nevermind23 Nevermind23 Awaiting requested review from Nevermind23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shpran @gabrielfs7