On client error throw, catch and handle exception

src/ElasticSearch.php

@@ -123,7 +123,7 @@ public function query($queryString, $type, $start = 0, $count = 10, $order = '_i
     /**
      * (Re)Generate the index for a given resource
      * @param IndexIterator|array $documents
-     * @return integer
+     * @throws ClientErrorResponseException
      */
     public function index($documents = []): int
     {

src/ElasticSearchIndexer.php

@@ -22,6 +22,7 @@
 namespace oat\tao\elasticsearch;
 
 use Elasticsearch\Client;
+use Elasticsearch\Common\Exceptions\ClientErrorResponseException;
 use Psr\Log\LoggerInterface;
 use RuntimeException;
 use Iterator;
@@ -74,6 +75,7 @@ public function getIndexNameByDocument(IndexDocument $document): string
     /**
      * @param Iterator $documents
      * @return int The number of indexed documents
+     * @throws ClientErrorResponseException
      */
     public function buildIndex(Iterator $documents): int
     {
@@ -101,7 +103,6 @@ public function buildIndex(Iterator $documents): int
 
             $params = $this->extendBatch('delete', $indexName, $document, $params);
             $params = $this->extendBatch('create', $indexName, $document, $params);
-            $params = $this->extendBatch('update', $indexName, $document, $params);
 
             $documents->next();
 
@@ -110,6 +111,10 @@ public function buildIndex(Iterator $documents): int
             if ($blockSize === self::INDEXING_BLOCK_SIZE) {
                 $clientResponse = $this->client->bulk($params);
 
+                if ($clientResponse['errors'] === true) {
+                    throw new ClientErrorResponseException($this->parseErrors($clientResponse));
+                }
+
                 $this->logger->debug('client response: '. json_encode($clientResponse));
 
                 $count += $blockSize;
@@ -121,7 +126,11 @@ public function buildIndex(Iterator $documents): int
         if ($blockSize > 0) {
             $clientResponse = $this->client->bulk($params);
 
-            $this->logger->debug('client response: '. json_encode($clientResponse));
+            if ($clientResponse['errors'] === true) {
+                throw new ClientErrorResponseException($this->parseErrors($clientResponse));
+            }
+
+            $this->logger->debug('client response: ' . json_encode($clientResponse));
 
             $count += $blockSize;
         }
@@ -141,7 +150,7 @@ public function deleteDocument($id): bool
             $deleteParams = [
                 'type' => '_doc',
                 'index' => $document['_index'],
-                'id' => $document['_id']
+                'id' => $document['_id'],
             ];
             $this->getClient()->delete($deleteParams);
 
@@ -154,6 +163,7 @@ public function deleteDocument($id): bool
     /**
      * @param array $ids
      * @param string $type
+     *
      * @return array
      */
     public function searchResourceByIds($ids = [])
@@ -214,4 +224,15 @@ private function extendBatch(string $action, string $indexName, IndexDocument $d
 
         return $params;
     }
+
+    private function parseErrors(array $clientResponse): string
+    {
+        $errors = '';
+
+        foreach ($clientResponse['items'] as $response) {
+            $response = reset($response);
+            $errors .= $response['error']['reason'];
+        }
+        return $errors;
+    }
 }

test/ElasticSearchIndexerTest.php

@@ -23,6 +23,7 @@
 namespace oat\tao\test\elasticsearch;
 
 use Elasticsearch\Client;
+use Elasticsearch\Common\Exceptions\ClientErrorResponseException;
 use oat\generis\test\TestCase;
 use oat\oatbox\log\LoggerService;
 use oat\tao\elasticsearch\ElasticSearchIndexer;
@@ -88,6 +89,49 @@ public function testGetIndexNameByDocumentForUnclassifieds(): void
         $this->assertSame(IndexerInterface::UNCLASSIFIEDS_DOCUMENTS_INDEX, $indexName);
     }
 
+    public function testBuildIndexBulkErrorResponse(): void
+    {
+        $this->expectException(ClientErrorResponseException::class);
+        $this->expectExceptionMessage('some reasonsome other reason');
+        $document = $this->createMock(IndexDocument::class);
+        $document->expects($this->any())
+            ->method('getBody')
+            ->willReturn([
+                'type' => [
+                    TaoOntology::CLASS_URI_ITEM,
+                ],
+            ]);
+
+        $document->expects($this->any())
+            ->method('getId')
+            ->willReturn('some_id');
+
+        $this->client
+            ->method('bulk')
+            ->willReturn([
+                'errors' => true,
+                'items' => [
+                    [
+                        [
+                            'error' => [
+                                'reason' => 'some reason',
+                            ],
+                        ],
+                    ],
+                    [
+                        [
+                            'error' => [
+                                'reason' => 'some other reason',
+                            ],
+                        ],
+                    ],
+                ],
+            ]);
+        $iterator = $this->createIterator([$document]);
+
+        $this->sut->buildIndex($iterator);
+    }
+
     public function testBuildIndex(): void
     {
         $document = $this->createMock(IndexDocument::class);