-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/AUT-2673/inline-figure-img #528
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d57654b
fix: Figure widget re-build on alignment change
marpesia e686533
fix: add showFigure param in Figcaption panel
marpesia f6b30ec
fix: add CSS styles to feedback on Figure panel
marpesia 73af5aa
fix: remove caption destroy code
marpesia 86fb44a
fix: rebuild editor on leave Figure
marpesia 6bf18d9
fix: refactor function with config param
marpesia 4967e53
fix: remove unnecesary check
marpesia 9119c90
fix: set config data to improve redeability
marpesia 237ed65
fix: move the parent rebuild to the change scope
marpesia fc1189f
fix: refactor the library location
marpesia 7cf054d
fix: refactor rebuild editor
marpesia a39aca8
fix: solve toggle position on prompt
marpesia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,3 +148,7 @@ | |
.bg-error { | ||
background-color: $errorBgColor; | ||
} | ||
|
||
textarea + .feedback-info { | ||
padding: 5px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -43,12 +43,17 @@ export const positionFloat = function positionFloat(widget, position) { | |||||
// Update DOM | ||||||
widget.$container.addClass(className); | ||||||
// Update model | ||||||
const prevClassName = widget.element.attr('class'); | ||||||
if (className) { | ||||||
widget.element.attr('class', className); | ||||||
} else { | ||||||
widget.element.removeAttr('class'); | ||||||
} | ||||||
|
||||||
|
||||||
if ((prevClassName || className.length) && prevClassName !== className) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Why test the value only for one variable and the length only for the other variable? Both are string, so it could be tested by value for both... suggestion:
Suggested change
|
||||||
// Re-build Figure widget to toggle between inline/block | ||||||
widget.refresh(widget.$container); | ||||||
} | ||||||
widget.$original.trigger('contentChange.qti-widget'); | ||||||
}; | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It could also have been turned into a restructured declaration as mentioned in the coding guide
If some parameters are mandatory and need to be given anyway, it could also be split into groups: