Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/aut 2673/inline figure img #533

Closed
wants to merge 12 commits into from
Closed

Hotfix/aut 2673/inline figure img #533

wants to merge 12 commits into from

Conversation

bziondik
Copy link
Contributor

@bziondik bziondik commented Nov 30, 2022 •
edited
Loading

@bziondik bziondik requested a review from Silvia-loza December 1, 2022 10:27
Silvia-loza
Silvia-loza approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@Silvia-loza Silvia-loza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes and bundles present. LGTM

Karol-Stelmaczonek
Karol-Stelmaczonek approved these changes Dec 7, 2022
View reviewed changes
Copy link

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@bziondik
Copy link
Contributor Author

bziondik commented Dec 9, 2022

No need, was made decision deliver latest version

@bziondik bziondik closed this Dec 9, 2022
@bziondik bziondik deleted the hotfix/AUT-2673/inline-figure-img branch December 9, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karol-Stelmaczonek Karol-Stelmaczonek Karol-Stelmaczonek approved these changes

@Silvia-loza Silvia-loza Silvia-loza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bziondik @Silvia-loza @Karol-Stelmaczonek @marpesia