Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking/tdr 9/handlebars 4 upgrade #2363

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

oatymart
Copy link
Contributor

@oatymart oatymart commented Jan 3, 2020

https://oat-sa.atlassian.net/browse/TR-3264
https://oat-sa.atlassian.net/wiki/spaces/FOUN/pages/144081031/Upgrade+Handlebars

  • remove Handlebars requireJS shims
  • bump dependencies in package*.json
  • rebundle JS
  • composer dependency update

@codeclimate
Copy link

codeclimate bot commented Jan 3, 2020

Code Climate has analyzed commit d7f1d9b and detected 0 issues on this pull request.

View more on Code Climate.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (57ae1b4) 27.58% compared to head (3931287) 27.58%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2363   +/-   ##
==========================================
  Coverage      27.58%   27.58%           
  Complexity     10978    10978           
==========================================
  Files            922      922           
  Lines          33919    33919           
==========================================
  Hits            9355     9355           
  Misses         24564    24564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Version

🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
❕ Some commits are not using the conventional commits formats. They will be ignored in version management.

Target Version 54.0.0
Last version 53.6.1

There are 2 BREAKING CHANGES, 1 feature, 0 fix

@oatymart oatymart marked this pull request as draft June 7, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants