Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1782/Implement the UI for the list of translations #4101

Merged
merged 16 commits into from
Sep 24, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Sep 19, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1782

Requires:

Also require extension-tao-tests and extension-tao-itemqti to be with the branch feat/HKD-6/integration

Summary

Implement a form component for managing the list of translations for a resource.

Also implement the API client to connect with the server.

Details

A component is now present in form/translation and connection with API services is given via services/translation.

The component shows:

  • a creation form to add a translation
  • a list of existing translations

When the user create a translation, or click the edit button, an event is triggered to command the editing.

image

How to test

  • checkout the branch: git checkout -t origin/feature/ADF-1782/translation-list-ui
  • make sure to install the np resources: cd tao/views && npm ci
  • select an item and see the translate button
  • click the translate button (note: you need the item to be ready for translation, otherwise, the component will only show a placeholder message)

The following feature flags will also be needed:

FEATURE_FLAG_TRANSLATION_ENABLED=true
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER=true
FEATURE_FLAG_TRANSLATION_DEVELOPER_MODE=true

views/package.json Outdated Show resolved Hide resolved
@jsconan jsconan marked this pull request as ready for review September 20, 2024 14:55
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! :)

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, validated locally.

Nice job! 👍👍

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@jsconan jsconan merged commit e8375f6 into feat/HKD-6/integration Sep 24, 2024
1 check passed
@jsconan jsconan deleted the feature/ADF-1782/translation-list-ui branch September 24, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants