-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ADF-1782/Implement the UI for the list of translations #4101
Merged
jsconan
merged 16 commits into
feat/HKD-6/integration
from
feature/ADF-1782/translation-list-ui
Sep 24, 2024
Merged
Feature/ADF-1782/Implement the UI for the list of translations #4101
jsconan
merged 16 commits into
feat/HKD-6/integration
from
feature/ADF-1782/translation-list-ui
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsconan
commented
Sep 19, 2024
gabrielfs7
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! :)
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
1 task
gabrielfs7
approved these changes
Sep 23, 2024
shaveko
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, validated locally.
Nice job! 👍👍
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/ADF-1782
Requires:
Also require
extension-tao-tests
andextension-tao-itemqti
to be with the branchfeat/HKD-6/integration
Summary
Implement a form component for managing the list of translations for a resource.
Also implement the API client to connect with the server.
Details
A component is now present in
form/translation
and connection with API services is given viaservices/translation
.The component shows:
When the user create a translation, or click the edit button, an event is triggered to command the editing.
How to test
git checkout -t origin/feature/ADF-1782/translation-list-ui
cd tao/views && npm ci
The following feature flags will also be needed: