Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adf 1789/side by side authoring #4119

Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 24, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1789

Summary

Add support for querying multiple resources when listing the translations.

Details

The id parameter can now accept an array of URI. In this case, the language URI is necessary.

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well.

Nice job!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@jsconan jsconan merged commit 9aba5cb into feat/HKD-6/integration Oct 30, 2024
1 check passed
@jsconan jsconan deleted the feature/ADF-1789/side-by-side-authoring branch October 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants