Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ADF-1789/small issues #4120

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 30, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1789

Summary

Fix for 2 small issues:

  • when deleting a translation, the language needs to be available again in the dropdown
  • the original resource language must not be available for translation

Details

Update the translation form component.

How to test

  • check out the branch: git checkout -t origin/fix/ADF-1789/small-issues
  • make sure to have the companion branch checked out and up to date too on the other extensions: feat/HKD-6/integration
  • make sure to have the Feature Flags activated
FEATURE_FLAG_TRANSLATION_ENABLED=true
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER=true
  • make sure to have the Item Translator role assigned to your user
  • have an item ready for translation
  • add a translation and delete it: the language must be available again in the dropdown list
  • the language of the main item must not be available for translation

@jsconan jsconan requested review from gabrielfs7 and shaveko October 30, 2024 15:59
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good! Thanks, JS!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally, issueas are fixed. Nice job!

@jsconan jsconan merged commit df4a780 into feat/HKD-6/integration Oct 31, 2024
1 check passed
@jsconan jsconan deleted the fix/ADF-1789/small-issues branch October 31, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants