Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1789/Sync items translations #4122

Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Nov 4, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1789

Summary

Add a sync action to the service helper for synchronizing a translation

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and works well.

Please fix the ticket link in the description of the PR.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@jsconan jsconan merged commit ad1d640 into feat/HKD-6/integration Nov 4, 2024
1 check passed
@jsconan jsconan deleted the feature/ADF-1789/sync-items-translations branch November 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants