fix: unique identifiers #4124
Merged
fix: unique identifiers #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfs7
reviewed
Nov 6, 2024
| { | ||
| public function getOriginalResourceUri(core_kernel_classes_Resource $resource): ?string | ||
| { | ||
| $property = $resource->getProperty(TaoOntology::PROPERTY_TRANSLATION_ORIGINAL_RESOURCE_URI); |
There was a problem hiding this comment.
I see the value of this class, but some points:
- It will be the first time we are creating a class to shortcut ontology getProperty...
- If we keep calling
$resource->getPropertyall the time in a loop or other places, this is actually a performance issue. We would have to cache it.
gabrielfs7
reviewed
Nov 6, 2024
| $this->featureFlagChecker = $featureFlagChecker; | ||
| } | ||
|
|
||
| public function retrieve(core_kernel_classes_Resource $resource): ?string |
There was a problem hiding this comment.
I see the value of this class, but some points:
- It will be the first time we are creating a class to shortcut ontology getProperty...
- If we keep calling
$resource->getPropertyall the time in a loop or other places, this is actually a performance issue. We would have to cache it. - If this is a uniqueId retriever, shouldn't it contain the logic to get the unique id in any case? Calling the Proxy you created?
gabrielfs7
approved these changes
Nov 6, 2024
gabrielfs7
reviewed
Nov 6, 2024
| $this->qtiIdentifierSetters[$resourceType] = $qtiIdentifierSetter; | ||
| } | ||
|
|
||
| public function __invoke(core_kernel_classes_Resource $item): void |
There was a problem hiding this comment.
We should call it more agnostically $resource
Suggested change
| public function __invoke(core_kernel_classes_Resource $item): void | |
| public function __invoke(core_kernel_classes_Resource $resource): void |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unique identifiers + removing unnecessary classes