Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API for "Fit" method triggerring "ValueError: output array is read-only" #16

Open
gmaze opened this issue Jan 23, 2020 · 6 comments
Assignees
Labels
API API design documentation Documentation content

Comments

@gmaze
Copy link
Member

gmaze commented Jan 23, 2020

Following the issue #15, one need to improve the API to give users some indications on how to address (temporary) this bug:

When the error is raised, provide a helpful log message to users to point them toward the (temporary) fix: Try with dask_ml backend.

@gmaze gmaze added documentation Documentation content API API design labels Jan 23, 2020
@DaniJonesOcean
Copy link
Contributor

Do you mind if I try to fix this issue? It would be good GitHub practice for me.

@gmaze
Copy link
Member Author

gmaze commented Jan 23, 2020

Sure ! all contributions are more than welcome !
(by the way I need to add a CONTRIBUTING file to the project)

@DaniJonesOcean
Copy link
Contributor

DaniJonesOcean commented Feb 12, 2020

Thanks Guillaume. I probably won't get to this until after Ocean Sciences - I hope that's okay. If you have some time pressure to get this done and want to take care of it yourself, I understand.

@gmaze
Copy link
Member Author

gmaze commented Feb 14, 2020

I won't have time to fix this before OS20 either, so let's keep it this way a little more !

@DaniJonesOcean
Copy link
Contributor

We are slowly emerging from lockdown here in the UK...I'm hoping to spend more time working in-depth (e.g. this issue and other coding projects). Is this still a relevant issue?

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2020

Hi @DanJonesOcean
Yes, this is still relevant !
We have more people using pyxpcm in different projet here, so the software still needs to fix this issue
g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API design documentation Documentation content
Projects
None yet
Development

No branches or pull requests

2 participants