-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new object property has roost for issue #453 #672
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
566eb46
added new object property has roost for issue #453
diatomsRcool a722436
add habitat to other_import to be used as domain/range in relations
wdduncan 952cbbc
change range of to
wdduncan ad439b1
change dc:creator to dcterms:contributor
wdduncan 15e1380
remove habitat from other_imports
wdduncan ecc9176
update branch with master
wdduncan b629fe0
add "habitat" it envo_terms
wdduncan f00d557
fix dc/dce confusions
wdduncan a2e82f8
add habitat class using ODK
wdduncan 33bed46
Update ro-edit.owl
matentzn 6ef9d13
Delete other_import.owl
matentzn ad6d846
merge in updates from master
wdduncan c34e8bf
add domain of organism
wdduncan a3eac0e
add range habitat
wdduncan 875a457
adding example of usage for has roost
diatomsRcool 3f63c09
Merge branch 'master' into thessen-1
anitacaron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please give a concrete example with terms in existing OBO ontologies as subject/predicate annotated with IAO:0000112 (example of usage)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthoyt Do you mean just an example of how the term is used? E.g., "bird has roost some nest"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that would be great, as long as it gives explicit references to Bird and Nest using OBO PURLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think examples of usage have to use obo purls. Free text is fine. The purpose of "example of usage" is to provide extra context to disambiguate the term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just hoping there is a realistic, demonstrable scenario in which this relation will get used... like if there are no IRIs corresponding to entities that would actually use this, then how can we be sure this will be a useful relation? This is for the benefit of future users, who without a concrete example might not be able to figure out how to use the relationship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. That is the purpose of the annotation. We haven't required that OBO PURLs be used. See examples for
example of usage
in adjacent to, capable of, characteristic of, and many more ...But @diatomsRcool if you can provide an example OBO PURLs, that would be nice.