Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 5.3 #159

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

kit-ty-kate
Copy link
Contributor

effect is now a keyword

effect is now a keyword
@kit-ty-kate
Copy link
Contributor Author

cc @gerdstolpmann

@kit-ty-kate
Copy link
Contributor Author

ping @gerdstolpmann if you have some time. If not is there anyone else able to do a release?

@cspiel cspiel merged commit d4f8cac into ocaml-omake:master Dec 6, 2024
@cspiel
Copy link
Collaborator

cspiel commented Dec 6, 2024

@kit-ty-kate: Sorry, but I totally forgot that I have merge rights.
THX for your patch.

@kit-ty-kate
Copy link
Contributor Author

no worries! If you'd be able to push a release commit similar to #156 and push a tag, i'm happy doing the publishing part of the release (submit to opam-repository) if that helps

@cspiel
Copy link
Collaborator

cspiel commented Dec 6, 2024

AFAICT it looks good.
If something is odd gimme a buzz.
And don't tell me I'm terrific.

@kit-ty-kate
Copy link
Contributor Author

Apart from a bit of parsing issues (fixed by #161) i had no problem so far. I've opened the PR in: ocaml/opam-repository#27043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants