Default maintenance_intent to (latest)

Signed-off-by: ArthurW <arthur@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>

Author: art-w

otherlibs/dune-site/test/run.t

@@ -169,6 +169,7 @@ Test with an opam like installation
     ]
     ["dune" "install" "-p" name "--create-install-files" name]
   ]
+  x-maintenance-intent: ["(latest)"]
 
   $ dune build -p a --promote-install-files=false @install
 

otherlibs/dune-site/test/run_2_9.t

@@ -157,6 +157,7 @@ Test with an opam like installation
     ]
     ["dune" "install" "-p" name "--create-install-files" name]
   ]
+  x-maintenance-intent: ["(latest)"]
 
   $ dune build -p a --promote-install-files="false" @install
 

src/dune_config_file/dune_config_file.ml

@@ -365,7 +365,7 @@ module Dune_config = struct
     ; project_defaults =
         { authors = Some [ "Author Name <author@example.com>" ]
         ; maintainers = Some [ "Maintainer Name <maintainer@example.com>" ]
-        ; maintenance_intent = Some [ "(latest)" ]
+        ; maintenance_intent = None
         ; license = Some [ "LICENSE" ]
         }
     ; experimental = []

src/dune_rules/opam_create.ml

@@ -228,7 +228,10 @@ let opam_fields project (package : Package.t) =
   in
   let list_fields =
     [ "maintainer", Package_info.maintainers info
-    ; "x-maintenance-intent", Package_info.maintenance_intent info
+    ; ( "x-maintenance-intent"
+      , match Package_info.maintenance_intent info with
+        | None -> Some [ "(latest)" ]
+        | x -> x )
     ; "authors", Package_info.authors info
     ; ( "license"
       , match Package_info.license info with

test/blackbox-tests/test-cases/describe/describe.t

@@ -1373,4 +1373,5 @@ opam file listing
       \"@doc\" {with-doc}
     ]
   ]
+  x-maintenance-intent: [\"(latest)\"]
   "))

test/blackbox-tests/test-cases/dune-init.t/run.t

@@ -403,6 +403,7 @@ And the opam file will be generated as expected
     ]
   ]
   dev-repo: "git+https://github.com/username/reponame.git"
+  x-maintenance-intent: ["(latest)"]
 
 We can build and run the resulting executable:
 
@@ -513,6 +514,7 @@ And the opam file will be generated as expected
     ]
   ]
   dev-repo: "git+https://github.com/username/reponame.git"
+  x-maintenance-intent: ["(latest)"]
 
 And we we can run the tests:
 

test/blackbox-tests/test-cases/dune-package.t/run.t

@@ -177,6 +177,7 @@ Install as opam does
       "@doc" {with-doc}
     ]
   ]
+  x-maintenance-intent: ["(latest)"]
 
   $ (cd a; "dune" "build" "-p" a "@install")
 

test/blackbox-tests/test-cases/dune-project-meta/dune-dep.t

@@ -191,6 +191,7 @@ the doc dependencies:
     ]
     ["dune" "install" "-p" name "--create-install-files" name]
   ]
+  x-maintenance-intent: ["(latest)"]
 
   $ cat > dune-project <<EOF
   > (lang dune 3.0)
@@ -215,6 +216,7 @@ the doc dependencies:
       "@doc" {with-doc}
     ]
   ]
+  x-maintenance-intent: ["(latest)"]
 
   $ cat > dune-project <<EOF
   > (lang dune 3.0)
@@ -240,3 +242,4 @@ the doc dependencies:
       "@doc" {with-doc}
     ]
   ]
+  x-maintenance-intent: ["(latest)"]

test/blackbox-tests/test-cases/dune-project-meta/github2927.t

@@ -30,3 +30,4 @@ Reproduction case for #2927
       "@doc" {with-doc}
     ]
   ]
+  x-maintenance-intent: ["(latest)"]

test/blackbox-tests/test-cases/dune-project-meta/v11-1.t

@@ -29,3 +29,4 @@ Generation of opam files with lang dune >= 1.11
       "@doc" {with-doc}
     ]
   ]
+  x-maintenance-intent: ["(latest)"]