From e58994a4c5a01f910adf0b3aff7aeac4df0df699 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Wed, 30 Oct 2019 02:06:26 +0900 Subject: [PATCH] Do not interpret deps for empty alias Signed-off-by: Rudi Grinberg --- src/dune/simple_rules.ml | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/dune/simple_rules.ml b/src/dune/simple_rules.ml index 5709f72f103..eabf1ee4ac0 100644 --- a/src/dune/simple_rules.ml +++ b/src/dune/simple_rules.ml @@ -15,13 +15,8 @@ module Alias_rules = struct let dir = Alias.dir alias in SC.add_alias_action sctx alias ~dir ~loc ~locks ~stamp build - let add_empty sctx ~loc ~expander ~alias ~deps ~stamp = - let action = - let open Build.O in - SC.Deps.interpret_named sctx ~expander deps - |> Build.ignore - >>> Build.progn [] - in + let add_empty sctx ~loc ~alias ~stamp = + let action = Build.return (Action.Progn []) in add sctx ~loc ~alias ~stamp action end @@ -89,8 +84,7 @@ let user_rule sctx ?extra_bindings ~dir ~expander (rule : Rule.t) = let stamp = Alias_rules.stamp ~deps:rule.deps ~action ~extra_bindings in - Alias_rules.add_empty sctx ~alias ~loc:(Some rule.loc) ~deps:rule.deps - ~expander ~stamp); + Alias_rules.add_empty sctx ~alias ~loc:(Some rule.loc) ~stamp); Path.Build.Set.empty | true -> ( let targets : Expander.Targets.t = @@ -187,9 +181,7 @@ let alias sctx ?extra_bindings ~dir ~expander (alias_conf : Alias_conf.t) = in let loc = Some alias_conf.loc in match Expander.eval_blang expander alias_conf.enabled_if with - | false -> - Alias_rules.add_empty sctx ~loc ~expander ~alias ~deps:alias_conf.deps - ~stamp + | false -> Alias_rules.add_empty sctx ~loc ~alias ~stamp | true -> let locks = interpret_locks ~expander alias_conf.locks in let action =