-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add or remove dune from package sets to allow resolving packages depending on it #11103
fix: Add or remove dune from package sets to allow resolving packages depending on it #11103
Conversation
b7ac875
to
76ce2c5
Compare
dune
to existing packages to allow resolvingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question to understand but it LGTM 👍
I've changed the PR from doing 1. to 2, as I didn't like how we construct a fake |
76ce2c5
to
db5505a
Compare
We need to do a combination of 1 and 2. We need to pick the correct deps for a formula like So we give the right dune version when evaluating the formula and then filtering out dune from the evaluated list. We do the same for external deps as well. I pushed something along those lines. |
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
220cb43
to
f1d0556
Compare
There's multiple ways to go about it:
dune_rpc
or whether that would even be the right thing, so I set the version todev
.dune
from the dependency formulas.Dependency_formula.remove_package formula (Package_name.Set.singleton Dune_dep.name)
is an alternate solution.Fixes #11096