ox: keep compat with oxcaml/oxcaml#main #12846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-rlkrsornmuok
branch
from
ef733e3 to
8f0837d
Compare
We check and fix compatability with the latest OxCaml. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-rlkrsornmuok
branch
from
8f0837d to
adefe13
Compare
art-w
approved these changes
Dec 2, 2025
Collaborator
art-w
left a comment
art-w
left a comment
There was a problem hiding this comment.
Thanks! For context, we are trying to avoid the next release of OxCaml having to ship a patched version of dune (like happened before)... but we are not yet sure of which breaking changes from the OxCaml trunk will be kept or not.
Collaborator
Author
|
So far the changes required are harmless. Just eta-expansions of some functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be tested with
We also add a CI job to test the oxcaml bootstrap so that we don't break compatability with the version in the flake. In the future this can be bumped as needed.