Skip to content

Use DUNE_CACHE_ROOT instead of XDG_CACHE_HOME in toolchains/revstore caches #12858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElectreAAS wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use DUNE_CACHE_ROOT instead of XDG_CACHE_HOME in toolchains/revstore caches #12858

ElectreAAS wants to merge 7 commits into from

Conversation

@ElectreAAS
Copy link
Collaborator

@ElectreAAS ElectreAAS commented Dec 3, 2025

This PR is an alternate version of #11612, implementing the 'breaking' option discussed here
It fixes #11584, and helps (but does not fix) #11585.
To recap:

Current behaviour With this PR
DUNE_CACHE_ROOT defaults to XDG/dune/db XDG/dune/
Build cache DUNE_CACHE_ROOT or XDG/dune/db DUNE_CACHE_ROOT/db or XDG/dune/db
Git repo cache  XDG/dune/git-repo only DUNE_CACHE_ROOT/git-repo or XDG/dune/git-repo
Lmdb cache XDG/dune/rev_store only DUNE_CACHE_ROOT/rev_store or XDG/dune/rev_store
Toolchains cache XDG/dune/toolchains only DUNE_CACHE_ROOT/toolchains or XDG/dune/toolchains

@ElectreAAS
Don't use XDG_CACHE_HOME directly, use DUNE_CACHE_ROOT instead
25b0b4d 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Expand test to show difference between xdg and dune_cache_dir
c2cd561 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Implement 'compromise' option: DUNE_CACHE_HOME
c13326f 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Move revstore/toolchains cache out of dune_cache_storage and into `…
f72319c 
…dune_util`

Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Bring in the 'rev_store' cache along into dune_util.
8791924 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Implement the 'breaking' option instead of the 'compromise' one.
9652dd5 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS
Added changes entry
52e6c3f 
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
@ElectreAAS ElectreAAS mentioned this pull request Dec 3, 2025
Open
@Alizter Alizter requested review from Alizter and rgrinberg December 3, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrinberg rgrinberg Awaiting requested review from rgrinberg

@Alizter Alizter Awaiting requested review from Alizter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toolchains cache does not follow DUNE_CACHE_ROOT

1 participant

@ElectreAAS