fix: improve error message for status db #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__improve_error_message_for_status_db
branch
from
b372e74
to
b20d343
Compare
|
What's the point however? Isn't |
|
Coq has the qualified option. Moreover, I'm going to lift the requirement for OCaml as well. |
|
@rgrinberg In that case looks fine. I guess you can't write a test to for the behaviour yet without coq lang right? If you lift the restriction on OCaml we should remember to add |
Alizter
reviewed
Nov 15, 2022
Alizter
approved these changes
Nov 15, 2022
|
It's just an error message anyway. There's more important things to test. |
When we tell the user a stanza is forbidden under [(include_subdirs $type)] we should write the correct $type rather than guess it's [unqualified] Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: a1282255-744e-4d60-931a-4f2b323cc143
rgrinberg
force-pushed
the
ps/rr/fix__improve_error_message_for_status_db
branch
from
b20d343
to
a7f2886
Compare
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 16, 2022
* main: test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485) chore(nix): make it faster to get melange (ocaml#6347) refactor: status db style tweaks (ocaml#6478) fix: improve error message for status db (ocaml#6479) refactor: remove unused [flags] parameter (ocaml#6480) refactor(ctypes): remove pesky aliases (ocaml#6482) chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484) feature(coq): automatic detection of native chore(coq): bump Coq lang to 0.7 test: disable formatting for a single dune file (ocaml#6465) refactor: clean up module compilation (ocaml#6461) doc: add button to copy code blocks in Dune manual (ocaml#6428) refactor: deforest a set conversion (ocaml#6473) refactor: remove temporary map used for sorting (ocaml#6472) fix(melange): handle include_subdirs unqualified (ocaml#6475)
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 16, 2022
* main: test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485) chore(nix): make it faster to get melange (ocaml#6347) refactor: status db style tweaks (ocaml#6478) fix: improve error message for status db (ocaml#6479) refactor: remove unused [flags] parameter (ocaml#6480) refactor(ctypes): remove pesky aliases (ocaml#6482) chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484) feature(coq): automatic detection of native chore(coq): bump Coq lang to 0.7 test: disable formatting for a single dune file (ocaml#6465) refactor: clean up module compilation (ocaml#6461) doc: add button to copy code blocks in Dune manual (ocaml#6428) refactor: deforest a set conversion (ocaml#6473) refactor: remove temporary map used for sorting (ocaml#6472) fix(melange): handle include_subdirs unqualified (ocaml#6475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tell the user a stanza is forbidden under [(include_subdirs
$type)] we should write the correct $type rather than guess it's
[unqualified]
Adding Ali as a reviewer as this only affects error messages for coq
Signed-off-by: Rudi Grinberg me@rgrinberg.com