refactor: move Dune_util.Value #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the [Value] module to [Dune_lang]. Logically this represents values that may be expanded by our percent forms so it belongs to the frontend. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 28f3b84e-1269-46a5-a7ec-5c1c5e504af9 -->
anmonteiro
approved these changes
Apr 19, 2023
Alizter
approved these changes
Apr 19, 2023
snowleopard
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the [Value] module to [Dune_lang]. Logically this represents values
that may be expanded by our percent forms so it belongs to the frontend.
Signed-off-by: Rudi Grinberg me@rgrinberg.com