refactor(dap): remove unnecessary intermediate type #8018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the followin type: ```ocaml type t = | File of Path.t | Glob of Path.t * Glob.t ``` That is exactly the same type as what we use to represent dune-action-plugin dependencies except it uses typed paths [Path.t] instead of raw strings like the dune-action-plugin It was used as an intermediate stage when converting DAP dependencies into dune dependencies. So previously, the conversions would go as: ``` DAP with string paths -> DAP with Path.t -> Dep.Set.t ``` The intermediate stage is unnecessary, and now we just convert: ``` DAP with string paths -> Dep.Set.t ``` The new code is both shorter, simpler, and faster. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: c3c2fac8-92fe-43c4-94f7-25dd1b51a8e3 -->
|
Looks good, any numbers on the "faster"? |
rgrinberg
deleted the
ps/rr/refactor_dap___remove_unnecessary_intermediate_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the following type:
That is exactly the same type as what we use to represent
dune-action-plugin dependencies except it uses typed paths [Path.t]
instead of raw strings like the dune-action-plugin
It was used as an intermediate stage when converting DAP dependencies
into dune dependencies. So previously, the conversions would go as:
The intermediate stage is unnecessary, and now we just convert:
The new code is both shorter, simpler, and faster.
Signed-off-by: Rudi Grinberg me@rgrinberg.com