fix(pkg): Check that git repo dir is accessible #9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of going ahead and running git against something that is not an accessible directory, this will at least raise an exception. Are there better ways to solve it? Except for showing a possibly better error message, not really - if someone has replaced the folder with something we can't access there is no other option than to fail in some way or other. Signed-off-by: Marek Kubica <marek@tarides.com>
|
One option would be to raise a user error and add a hint about deleting the directory, especially if its only Dune that is using it. |
Alizter
reviewed
Oct 29, 2023
|
Thanks. Merged with a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of going ahead and running git against something that is not an accessible directory, this will at least raise an exception.
Are there better ways to solve it? Except for showing a possibly better error message, not really - if someone has replaced the folder with something we can't access there is no other option than to fail in some way or other.