Add a new command to extract expression into a fresh let binding.

Author: Tim-ats-d

CHANGES.md

@@ -10,7 +10,6 @@ unreleased
     - `inlay-hints` fix inlay hints on function parameters (#1923)
     - Fix issues with ident validation and Lid comparison for occurrences (#1924)
     - Handle class type in outline (#1932)
-    - Handle object expression inside a let in outline (#1936)
   + ocaml-index
     - Improve the granularity of index reading by segmenting the marshalization
       of the involved data-structures. (#1889)

doc/dev/PROTOCOL.md

@@ -485,6 +485,25 @@ The result is returned as a list of:
 }
 ```
 
+### `refactor-extract-region -start <position> -stop <position> -extract-name <name>`
+
+```
+    -start <position>  Where extracted region start
+    -stop <position>  Where extracted region end
+    -extract-name <name>  Name used for the generated let binding
+```
+
+Returns the string `Nothing to do` (if extractor is not ables to select an expression to extract in the given position interval) or the following object:
+
+```javascript
+{
+  'start': position, // the start of the region to be substituted
+  'end': position, // the end of the region to be substituted
+  'content' string, // the content of the substitution
+  'selection_range': location // the location where to position the cursor for easy renaming of the generated let binding 
+}
+```
+
 ### `syntax-document -position <position>`
 
 	-position <position>  The position of the keyword to be documented

src/analysis/parsetree_utils.ml

@@ -1,5 +1,20 @@
+open Std
+
 open Parsetree
 
 type nonrec constant_desc = constant_desc
 
 let constant_desc c = c.pconst_desc
+
+let filter_attr =
+  let default = Ast_mapper.default_mapper in
+  let keep attr =
+    let { Location.txt; _ }, _ = Ast_helper.Attr.as_tuple attr in
+    not (Std.String.is_prefixed ~by:"merlin." txt)
+  in
+  let attributes mapper attrs =
+    default.Ast_mapper.attributes mapper (List.filter ~f:keep attrs)
+  in
+  { default with Ast_mapper.attributes }
+
+let filter_expr_attr expr = filter_attr.Ast_mapper.expr filter_attr expr

src/analysis/parsetree_utils.mli

@@ -6,3 +6,5 @@ open Parsetree
 type nonrec constant_desc = constant_desc
 
 val constant_desc : constant -> constant_desc
+
+val filter_expr_attr : expression -> expression