Set inlay hints enabled by default for function params (#1517)

* Set `inlay hints` enable by default for `function params`

* Apply formatting

Author: xvw

ocaml-lsp-server/src/config_data.ml

@@ -5,7 +5,7 @@ module InlayHints = struct
   type t =
     { hint_pattern_variables : bool [@key "hintPatternVariables"] [@default false]
     ; hint_let_bindings : bool [@key "hintLetBindings"] [@default false]
-    ; hint_function_params : bool [@key "hintFunctionParams"] [@default false]
+    ; hint_function_params : bool [@key "hintFunctionParams"] [@default true]
     }
   [@@deriving_inline yojson] [@@yojson.allow_extra_fields]
 
@@ -81,7 +81,7 @@ module InlayHints = struct
                   | Ppx_yojson_conv_lib.Option.Some v -> v)
              ; hint_function_params =
                  (match hint_function_params_value with
-                  | Ppx_yojson_conv_lib.Option.None -> false
+                  | Ppx_yojson_conv_lib.Option.None -> true
                   | Ppx_yojson_conv_lib.Option.Some v -> v)
              }))
      | _ as yojson ->

ocaml-lsp-server/test/e2e-new/inlay_hints.ml

@@ -5,7 +5,7 @@ let apply_inlay_hints
       ?range
       ?(hint_pattern_variables = false)
       ?(hint_let_bindings = false)
-      ?(hint_function_params = true)
+      ?hint_function_params
       ~source
       ()
   =
@@ -25,18 +25,19 @@ let apply_inlay_hints
     let textDocument = TextDocumentIdentifier.create ~uri in
     InlayHintParams.create ~textDocument ~range ()
   in
+  let regular_config =
+    [ "hintPatternVariables", `Bool hint_pattern_variables
+    ; "hintLetBindings", `Bool hint_let_bindings
+    ]
+    @
+    match hint_function_params with
+    | None -> []
+    | Some hint_function_params -> [ "hintFunctionParams", `Bool hint_function_params ]
+  in
   let inlay_hints =
     Test.run_request
       ~prep:(fun client -> Test.openDocument ~client ~uri ~source)
-      ~settings:
-        (`Assoc
-            [ ( "inlayHints"
-              , `Assoc
-                  [ "hintPatternVariables", `Bool hint_pattern_variables
-                  ; "hintLetBindings", `Bool hint_let_bindings
-                  ; "hintFunctionParams", `Bool hint_function_params
-                  ] )
-            ])
+      ~settings:(`Assoc [ "inlayHints", `Assoc regular_config ])
       (InlayHint request)
   in
   match inlay_hints with