-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] dune (1.4.0) #12774
[new release] dune (1.4.0) #12774
Conversation
CHANGES: - Do not fail if the output of `ocamlc -config` doesn't include `standard_runtime` (ocaml/dune#1326, @diml) - Let `Configurator.V1.C_define.import` handle negative integers (ocaml/dune#1334, @Chris00) - Re-execute actions when a target is modified by the user inside `_build` (ocaml/dune#1343, fix ocaml/dune#1342, @diml) - Pass `--set-switch` to opam (ocaml/dune#1341, fix ocaml/dune#1337, @diml) - Fix bad interaction between multi-directory libraries the `menhir` stanza (ocaml/dune#1373, fix ocaml/dune#1372, @diml) - Integration with automatic formatters (ocaml/dune#1252, fix ocaml/dune#1201, @emillon) - Better error message when using `(self_build_stubs_archive ...)` and `(c_names ...)` or `(cxx_names ...)` simultaneously. (ocaml/dune#1375, fix ocaml/dune#1306, @nojb) - Improve name detection for packages when the prefix isn't an actual package (ocaml/dune#1361, fix ocaml/dune#1360, @rgrinberg) - Support for new menhir rules (ocaml/dune#863, fix ocaml/dune#305, @fpottier, @rgrinberg) - Do not remove flags when compiling compatibility modules for wrapped mode (ocaml/dune#1382, fix ocaml/dune#1364, @rgrinberg) - Fix reason support when using `staged_pps` (ocaml/dune#1384, @charlesetc) - Add support for `enabled_if` in `rule`, `menhir`, `ocamllex`, `ocamlyacc` (ocaml/dune#1387, @diml) - Exit gracefully when a signal is received (ocaml/dune#1366, @diml) - Load all defined libraries recursively into utop (ocaml/dune#1384, fix ocaml/dune#1344, @rgrinberg) - Allow to use libraries `bytes`, `result` and `uchar` without `findlib` installed (ocaml/dune#1391, @nojb) - Take argument to self_build_stubs_archive into account. (ocaml/dune#1395, @nojb) - Fix bad interaction between `env` customization and vendored projects: when a vendored project didn't have its own `env` stanza, the `env` stanza from the enclosing project was in effect (ocaml/dune#1408, @diml) - Fix stop early bug when scanning for watermarks (ocaml/dune#1423, @diml)
☀️ All lint checks passed 9e08c98
☀️ Installability check (9775 → 9776)
|
poke @mseri for the Otherwise there seem to be a related problem that wasn't there before:
|
Thanks @kit-ty-kate the issue with It can be safely ignored though as it is not related to |
The archimedes failure seems to be there also with |
But the weird thing is that both didn't fail when tested for dune 1.3.0: https://ci.ocamllabs.io/ocaml/opam-repository/pr/12693?history=b093b1d937b5d9299bf3bb9ae9bdc200886016e5 |
If I had to guess, it's probably a race condition. Is it possible to restart the build? |
Yes, but you can do it on your own just by force pushing the branch even though it hasn't actually changed. That will trigger a new build. |
Archimedes does not use Dune to compile so this is odd. |
We have been imprecise. It is jupyter-Archimedes that fails because Archimedes.cairo appears to be an hidden library |
On 11 October 2018 at 16:36 GMT, Marcello Seri wrote:
We have been imprecise. It is jupyter-Archimedes that fails because
Archimedes.cairo appears to be an hidden library
I guess, this is because Archimedes predates the trend to have several packages for a given library so that dependencies are more explicit. jupyter-Archimedes should depend on cairo — but that may not completely fix the fact that Archimedes will compile archimedes.cairo when cairo is present, that will depend on the order of installation... ☹
The next version of Archimedes will be released as separate packages — but do not hold your breath, I intend to rewrite it from the ground up and split the functionality into several libraries.
|
as it's just from datakit ci, everyone can just relaunch the build by clicking "rebuild". It would avoid unnecessary rebuilds |
Anyways it doesn’t really matter now as @Chris00 clarified how jupyter-archimedes will build correctly only if cairo happens to be compiled before archimedes. So this failure is not dune’s fault |
CHANGES:
Do not fail if the output of
ocamlc -config
doesn't includestandard_runtime
(Do not fail if standard_runtime is missing in the output ofocamlc -config
dune#1326, @diml)Let
Configurator.V1.C_define.import
handle negative integers(Configurator: handle negative numbers dune#1334, @Chris00)
Re-execute actions when a target is modified by the user inside
_build
(Re-execute actions when a target is modified dune#1343, fix Dune doesn't recognize manual revert of executables dune#1342, @diml)Pass
--set-switch
to opam (Pass --set-switch to opam when opam 2.0.0 is detected dune#1341, fix dune triggers opam 2 to report spurious switch warnings dune#1337, @diml)Fix bad interaction between multi-directory libraries the
menhir
stanza (Fix #1372 dune#1373, fix include_subdirs + ocamllex + menhir dune#1372, @diml)
Integration with automatic formatters (Integration with auto formatters dune#1252, fix ocamlformat integration dune#1201, @emillon)
Better error message when using
(self_build_stubs_archive ...)
and(c_names ...)
or(cxx_names ...)
simultaneously.(Better error message when (self_build_stubs_archive ...) and (c_names ...) or (cxx_names ...) used simultaneously dune#1375, fix regression with 1.2.*: rule conflict dune#1306, @nojb)
Improve name detection for packages when the prefix isn't an actual package
(Better name detection dune#1361, fix
jbuilder subst -p name
leads to an error dune#1360, @rgrinberg)Support for new menhir rules (New interpretation of (menhir ...) stanzas. dune#863, fix jbuilder doesn't support menhir with --infer dune#305, @fpottier, @rgrinberg)
Do not remove flags when compiling compatibility modules for wrapped mode
(Do not reset flags for compatibility modules dune#1382, fix
(wrapped (transition ...))
doesn't set flags correctly dune#1364, @rgrinberg)Fix reason support when using
staged_pps
(Fix staged_pps to work with reason dune#1384, @charlesetc)Add support for
enabled_if
inrule
,menhir
,ocamllex
,ocamlyacc
(Support enabled_if in more places dune#1387, @diml)Exit gracefully when a signal is received (Exit gracefully when a signal is received dune#1366, @diml)
Load all defined libraries recursively into utop (Fix staged_pps to work with reason dune#1384, fix Load all project's libraries into utop dune#1344,
@rgrinberg)
Allow to use libraries
bytes
,result
anduchar
withoutfindlib
installed (meta builtins: add support for bytes/result packages dune#1391, @nojb)
Take argument to self_build_stubs_archive into account. (self_build_stubs_archive: do not ignore argument dune#1395, @nojb)
Fix bad interaction between
env
customization and vendoredprojects: when a vendored project didn't have its own
env
stanza,the
env
stanza from the enclosing project was in effect (Fix bad interaction between env stanza and vendored projects dune#1408,@diml)
Fix stop early bug when scanning for watermarks (fix stop early bug when scanning for watermarks dune#1423, @diml)