fix(typescript): const octokit = new Octokit();

octokit · Aug 13, 2021 · 51ee163 · 51ee163
1 parent b734489
commit 51ee163
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/types/index.d.ts b/packages/types/index.d.ts
@@ -258,14 +258,20 @@ export declare class Octokit<
    * You can optionally set the `auth` option to an access token string in order
    * to authenticate requests.
    */
-  constructor(options: { version?: TVersion } & { auth?: string } & TOptions);
+  constructor(
+    ...options: NonOptionalKeys<TOptions> extends undefined
+      ? [({ version?: TVersion } & { auth?: string } & TOptions)?]
+      : [{ version?: TVersion } & { auth?: string } & TOptions]
+  );
 
   /**
    * Constructor with setting `authStrategy`
    *
    * The `auth` option must be set to whatever the function passed as `authStrategy` accepts
    */
   constructor(
+    // we assume that if `authStrategy` is set, the `auth` option is always required,
+    // hence the constructor options are always required
     options: { version?: TVersion } & AuthStrategyAndOptions<TAuthStrategy> &
       TOptions
   );