Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conditional types based on provided API version #7

Merged
merged 36 commits into from
Aug 9, 2021
Merged

feat: conditional types based on provided API version #7

merged 36 commits into from
Aug 9, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jul 29, 2021 •
edited
Loading

closes #6, closes #8

@gr2m gr2m added Type: Feature New feature or request typescript labels Jul 29, 2021
gr2m added 21 commits August 2, 2021 15:12
@gr2m
build(package): lock file
7a7bb0c
@gr2m
WIP OMG ALL TESTS PASS
6992e74
@gr2m
moar type tests for GHES 3.1
280153c
@gr2m
GHES 3.0 usecase
9245d42
@gr2m
test: remove setting version in GHES 3.1/3.0 constructor
1233d6c
@gr2m
wip
d3e8e64
@gr2m
eject javascript-plugin-architecture-with-typescript-definitions
7a2317b
@gr2m
more tests
30a67f5
@gr2m
rename use-cases to tests
920cef9
@gr2m
add tests for plugins and defaults
38f4bd5
@gr2m
add more comments and add types for the baseUrl default
f095c36
@gr2m
typescript: ignore *.d.ts files that are not explicitly imported
29c9390
@gr2m
remove debug type
5b4c4df
@gr2m
tsconfig: exclude any implicit import of typesa
aea56c1
@gr2m
inherit .request() method when using .withDefaults()
a78b6ab
@gr2m
build: update lock file version to npm 7
1aee0d5
@gr2m
WIP move REST API types into workspaces
9dbaf72
@gr2m
WIP workspaces for core & types packages
c69e0ea
@gr2m
WIP move types for Octokit class into @octokit/types
1100759
@gr2m
WIP do not load all dotcom endpoints by default
fd38630
@gr2m
add typescript test, but do not run it by default as it is currently …
b88e8ad 
…failing. Will investigate in separate PR
@gr2m gr2m merged commit f376a96 into main Aug 9, 2021
@gr2m gr2m deleted the endpoints-types-based-on-version branch August 9, 2021 18:33
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Feature New feature or request typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create types for a set of endpoints for "github.com", "ghes-3.1", "ghes-3.0"
1 participant
@gr2m