From 48b4a61b49ccd322fff8e939474676d9c5b39891 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 5 Jan 2014 11:26:14 +1030 Subject: [PATCH] replaced all usages with v3 Accept header --- Octokit.Tests/Clients/ReleasesClientTests.cs | 6 +++--- Octokit.Tests/Http/JsonHttpPipelineTests.cs | 4 ++-- Octokit/Clients/ReleasesClient.cs | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Octokit.Tests/Clients/ReleasesClientTests.cs b/Octokit.Tests/Clients/ReleasesClientTests.cs index e28690819d..8a8408572a 100644 --- a/Octokit.Tests/Clients/ReleasesClientTests.cs +++ b/Octokit.Tests/Clients/ReleasesClientTests.cs @@ -21,7 +21,7 @@ public void RequestsCorrectUrl() client.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/releases"), null, - "application/vnd.github.manifold-preview"); + "application/vnd.github.v3"); } [Fact] @@ -47,7 +47,7 @@ public void RequestsCorrectUrl() client.Received().Post(Arg.Is(u => u.ToString() == "repos/fake/repo/releases"), data, - "application/vnd.github.manifold-preview"); + "application/vnd.github.v3"); } [Fact] @@ -82,7 +82,7 @@ public void UploadsToCorrectUrl() client.Received().Post( Arg.Is(u => u.ToString() == "https://uploads.test.dev/does/not/matter/releases/1/assets?name=example.zip"), rawData, - "application/vnd.github.manifold-preview", + "application/vnd.github.v3", Arg.Is(contentType => contentType == "application/zip")); } diff --git a/Octokit.Tests/Http/JsonHttpPipelineTests.cs b/Octokit.Tests/Http/JsonHttpPipelineTests.cs index 6315944730..1fe285479a 100644 --- a/Octokit.Tests/Http/JsonHttpPipelineTests.cs +++ b/Octokit.Tests/Http/JsonHttpPipelineTests.cs @@ -34,13 +34,13 @@ public void SetsRequestAcceptHeader() public void DoesNotChangeExistingAcceptsHeader() { var request = new Request(); - request.Headers.Add("Accept", "application/vnd.github.manifold-preview; charset=utf-8"); + request.Headers.Add("Accept", "application/vnd.github.v3; charset=utf-8"); var jsonPipeline = new JsonHttpPipeline(); jsonPipeline.SerializeRequest(request); Assert.Contains("Accept", request.Headers.Keys); - Assert.Equal("application/vnd.github.manifold-preview; charset=utf-8", request.Headers["Accept"]); + Assert.Equal("application/vnd.github.v3; charset=utf-8", request.Headers["Accept"]); } [Fact] diff --git a/Octokit/Clients/ReleasesClient.cs b/Octokit/Clients/ReleasesClient.cs index 7ae5994ca5..6ba6d73ed2 100644 --- a/Octokit/Clients/ReleasesClient.cs +++ b/Octokit/Clients/ReleasesClient.cs @@ -37,7 +37,7 @@ public Task> GetAll(string owner, string name) Ensure.ArgumentNotNullOrEmptyString(name, "repository"); var endpoint = ApiUrls.Releases(owner, name); - return ApiConnection.GetAll(endpoint, null, "application/vnd.github.manifold-preview"); + return ApiConnection.GetAll(endpoint, null, "application/vnd.github.v3"); } /// @@ -58,7 +58,7 @@ public Task CreateRelease(string owner, string name, ReleaseUpdate data Ensure.ArgumentNotNull(data, "data"); var endpoint = ApiUrls.Releases(owner, name); - return ApiConnection.Post(endpoint, data, "application/vnd.github.manifold-preview"); + return ApiConnection.Post(endpoint, data, "application/vnd.github.v3"); } /// @@ -80,7 +80,7 @@ public Task UploadAsset(Release release, ReleaseAssetUpload data) return ApiConnection.Post( endpoint, data.RawData, - "application/vnd.github.manifold-preview", + "application/vnd.github.v3", data.ContentType); } }